{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1746243263, "reponame":"libwebsockets", "desc":"libwebsockets lightweight C networking library", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://libwebsockets.org/repo/libwebsockets", "f":3, "items": [ {"schema":"libjg2-1", "cid":"6b2baca3ceb36d15367b75c680272b90", "commit": {"type":"commit", "time": 1618504913, "time_ofs": 60, "oid_tree": { "oid": "56800b1757cdd7854461ce5189d0b12f63efbf5b", "alias": []}, "oid":{ "oid": "2850de1afad7f4a9953a8494c11baec74f16cf7f", "alias": []}, "msg": "drivers: spi: avoid leaking uninitialized bits", "sig_commit": { "git_time": { "time": 1618504913, "offset": 60 }, "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" }, "sig_author": { "git_time": { "time": 1618317911, "offset": 120 }, "name": "kokke", "email": "spam@rowdy.dk", "md5": "b923ca502d835f68c3d9714da63cfb05" }}, "body": "drivers: spi: avoid leaking uninitialized bits\n\nBefore this commit, line 84 read 'u' before it had a value, on 1st for-loop iteration. See comment on line 84 below:\n\n82\t\tfor (n \u003d 0; n \u003c 8; n++) {\n83\t\t\tctx-\u003egpio-\u003eset(ctx-\u003eclk, inv);\n84\t\t\tu \u003d (u \u003c\u003c 1) | !!ctx-\u003egpio-\u003eread(ctx-\u003emiso); /* \u003c-- u is used uninitialized here */\n85\t\t\tctx-\u003egpio-\u003eset(ctx-\u003emosi, !!(u \u0026 0x80));\n86\t\t\tctx-\u003egpio-\u003eset(ctx-\u003eclk, !inv);\n87\t\t}\n" , "diff": "diff --git a/lib/drivers/spi/bitbang/lws-bb-spi.c b/lib/drivers/spi/bitbang/lws-bb-spi.c\nindex 285e53a..10f9bc5 100644\n--- a/lib/drivers/spi/bitbang/lws-bb-spi.c\n+++ b/lib/drivers/spi/bitbang/lws-bb-spi.c\n@@ -74,7 +74,8 @@ lws_bb_spi_write(lws_bb_spi_t *ctx, const uint8_t *buf, size_t len)\n static void\n lws_bb_spi_read(lws_bb_spi_t *ctx, uint8_t *buf, size_t len)\n {\n-\tuint8_t u, inv \u003d !!(ctx-\u003ebb_ops.bus_mode \u0026 LWSSPIMODE_CPOL);\n+\tuint8_t u \u003d 0;\n+\tuint8_t inv \u003d !!(ctx-\u003ebb_ops.bus_mode \u0026 LWSSPIMODE_CPOL);\n \n \twhile (len--) {\n \t\tint n;\n","s":{"c":1746243263,"u": 1642}} ],"g": 2397,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}