{"schema":"libjg2-1", "vpath":"/git/", "avatar":"/git/avatar/", "alang":"", "gen_ut":1752650665, "reponame":"openssl", "desc":"OpenSSL", "owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl", "f":3, "items": [ {"schema":"libjg2-1", "cid":"77e9116d6b1450710b3abd7709dc836f", "commit": {"type":"commit", "time": 1533718696, "time_ofs": 60, "oid_tree": { "oid": "892851545ba500599a1bb84d318b4629090bd258", "alias": []}, "oid":{ "oid": "b4f001eb1a9e0bd0fda8f3c7dfbccb6422ad8c47", "alias": []}, "msg": "Fix a missing call to SSLfatal", "sig_commit": { "git_time": { "time": 1533718696, "offset": 60 }, "name": "Matt Caswell", "email": "matt@openssl.org", "md5": "10f7b441a32d5790efad9fc68cae4af2" }, "sig_author": { "git_time": { "time": 1533560529, "offset": 60 }, "name": "Matt Caswell", "email": "matt@openssl.org", "md5": "10f7b441a32d5790efad9fc68cae4af2" }}, "body": "Fix a missing call to SSLfatal\n\nUnder certain error conditions a call to SSLfatal could accidently be\nmissed.\n\nReviewed-by: Ben Kaduk \u003ckaduk@mit.edu\u003e\nReviewed-by: Andy Polyakov \u003cappro@openssl.org\u003e\n(Merged from https://github.com/openssl/openssl/pull/6872)\n" , "diff": "diff --git a/ssl/statem/statem_srvr.c b/ssl/statem/statem_srvr.c\nindex 01b07a9..eb9070e 100644\n--- a/ssl/statem/statem_srvr.c\n+++ b/ssl/statem/statem_srvr.c\n@@ -2370,15 +2370,19 @@ int tls_construct_server_hello(SSL *s, WPACKET *pkt)\n \n if (!WPACKET_sub_memcpy_u8(pkt, session_id, sl)\n || !s-\u003emethod-\u003eput_cipher_by_char(s-\u003es3-\u003etmp.new_cipher, pkt, \u0026len)\n- || !WPACKET_put_bytes_u8(pkt, compm)\n- || !tls_construct_extensions(s, pkt,\n- s-\u003ehello_retry_request\n- \u003d\u003d SSL_HRR_PENDING\n- ? SSL_EXT_TLS1_3_HELLO_RETRY_REQUEST\n- : (SSL_IS_TLS13(s)\n- ? SSL_EXT_TLS1_3_SERVER_HELLO\n- : SSL_EXT_TLS1_2_SERVER_HELLO),\n- NULL, 0)) {\n+ || !WPACKET_put_bytes_u8(pkt, compm)) {\n+ SSLfatal(s, SSL_AD_INTERNAL_ERROR, SSL_F_TLS_CONSTRUCT_SERVER_HELLO,\n+ ERR_R_INTERNAL_ERROR);\n+ return 0;\n+ }\n+\n+ if (!tls_construct_extensions(s, pkt,\n+ s-\u003ehello_retry_request \u003d\u003d SSL_HRR_PENDING\n+ ? SSL_EXT_TLS1_3_HELLO_RETRY_REQUEST\n+ : (SSL_IS_TLS13(s)\n+ ? SSL_EXT_TLS1_3_SERVER_HELLO\n+ : SSL_EXT_TLS1_2_SERVER_HELLO),\n+ NULL, 0)) {\n /* SSLfatal() already called */\n return 0;\n }\n","s":{"c":1752650665,"u": 39296}} ],"g": 40725,"chitpc": 0,"ehitpc": 0,"indexed":0 , "ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}