{"schema":"libjg2-1",
"vpath":"/git/",
"avatar":"/git/avatar/",
"alang":"",
"gen_ut":1753169365,
"reponame":"openssl",
"desc":"OpenSSL",
"owner": { "name": "Andy Green", "email": "andy@warmcat.com", "md5": "c50933ca2aa61e0fe2c43d46bb6b59cb" },"url":"https://warmcat.com/repo/openssl",
"f":3,
"items": [
{"schema":"libjg2-1",
"cid":"79a1d3f1b3e7dfca319c1341aa8a0477",
"commit": {"type":"commit",
"time": 1495031622,
"time_ofs": 60,
"oid_tree": { "oid": "2b7458e05e4bf537153bf321cb03284ec053e29e", "alias": []},
"oid":{ "oid": "964f2788908e19b4faf370eb99652367672374e7", "alias": []},
"msg": "Add a test for a missing sig algs extension",
"sig_commit": { "git_time": { "time": 1495031622, "offset": 60 }, "name": "Matt Caswell", "email": "matt@openssl.org", "md5": "10f7b441a32d5790efad9fc68cae4af2" },
"sig_author": { "git_time": { "time": 1494932757, "offset": 60 }, "name": "Matt Caswell", "email": "matt@openssl.org", "md5": "10f7b441a32d5790efad9fc68cae4af2" }},
"body": "Add a test for a missing sig algs extension\n\nCheck that a missing sig algs extension succeeds if we are resuming.\n\nReviewed-by: Rich Salz \u003crsalz@openssl.org\u003e\n(Merged from https://github.com/openssl/openssl/pull/3478)"
,
"diff": "diff --git a/test/recipes/70-test_tls13psk.t b/test/recipes/70-test_tls13psk.t\nindex 48d1dde..23767f9 100644\n--- a/test/recipes/70-test_tls13psk.t\n+++ b/test/recipes/70-test_tls13psk.t\n@@ -42,15 +42,15 @@ use constant {\n ILLEGAL_EXT_SECOND_CH \u003d\u003e 1\n };\n \n-#Most PSK tests are done in test_ssl_new. This just checks sending a PSK\n-#extension when it isn't in the last place in a ClientHello\n+#Most PSK tests are done in test_ssl_new. This tests various failure scenarios\n+#around PSK\n \n #Test 1: First get a session\n (undef, my $session) \u003d tempfile();\n $proxy-\u003eclientflags(\u0022-sess_out \u0022.$session);\n $proxy-\u003esessionfile($session);\n $proxy-\u003estart() or plan skip_all \u003d\u003e \u0022Unable to start up Proxy for tests\u0022;\n-plan tests \u003d\u003e 4;\n+plan tests \u003d\u003e 5;\n ok(TLSProxy::Message-\u003esuccess(), \u0022Initial connection\u0022);\n \n #Test 2: Attempt a resume with PSK not in last place. Should fail\n@@ -94,6 +94,13 @@ $pskseen \u003d $ch2seen\n \u0026\u0026 defined ${$ch2-\u003eextension_data}{TLSProxy::Message::EXT_PSK};\n ok($ch2seen \u0026\u0026 !$pskseen, \u0022PSK hash does not match\u0022);\n \n+#Test 5: Attempt a resume without a sig agls extension. Should succeed because\n+# sig algs is not needed in a resumption.\n+$proxy-\u003eclear();\n+$proxy-\u003eclientflags(\u0022-sess_in \u0022.$session);\n+$proxy-\u003efilter(\u005c\u0026remove_sig_algs_filter);\n+$proxy-\u003estart();\n+ok(TLSProxy::Message-\u003esuccess(), \u0022Remove sig algs\u0022);\n \n unlink $session;\n \n@@ -129,3 +136,16 @@ sub modify_psk_filter\n }\n $message-\u003erepack();\n }\n+\n+sub remove_sig_algs_filter\n+{\n+ my $proxy \u003d shift;\n+ my $message;\n+\n+ # Only look at the first ClientHello\n+ return if $proxy-\u003eflight !\u003d 0;\n+\n+ $message \u003d ${$proxy-\u003emessage_list}[0];\n+ $message-\u003edelete_extension(TLSProxy::Message::EXT_SIG_ALGS);\n+ $message-\u003erepack();\n+}\n","s":{"c":1753169365,"u": 28227}}
],"g": 29034,"chitpc": 0,"ehitpc": 0,"indexed":0
,
"ab": 0, "si": 0, "db":0, "di":0, "sat":0, "lfc": "0000"}