[Libwebsockets] [libwebsockets] reserved identifier violation (#21)

"Andy Green (林安廸)" andy at warmcat.com
Fri Oct 25 16:22:05 CEST 2013


On 25/10/13 22:19, the mail apparently from Markus Elfring included:
> I would like to point out that identifiers like "|__LIBWEBSOCKET_H__|
> <https://github.com/warmcat/libwebsockets/blob/b4e800e333f66bec56ad22f6e3cf1455618d4305/lib/libwebsockets.h#L22>"
> and "|__ifaddrs_h__|
> <https://github.com/warmcat/libwebsockets/blob/b5b23199f6bea15344e942ac22f1a3fbf7164112/lib/getifaddrs.h#L43>"
> do not fit
> <https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29>
> to the expected naming convention of the C language standard.
> Would you like to adjust your selection for unique names?

Like for your cmake advice, if you would like to send a patch I'll 
consider it.

Frankly I don't see much trouble coming from not changing this one, but 
if there's a reasonable patch it's a lot easier to care.

-Andy

>
>> Reply to this email directly or view it on GitHub
> <https://github.com/warmcat/libwebsockets/issues/21>.
>




More information about the Libwebsockets mailing list