[Libwebsockets] [libwebsockets] Various Fixes (#78)
"Andy Green (林安廸)"
andy at warmcat.com
Fri Feb 28 02:03:00 CET 2014
On 28/02/14 08:37, the mail apparently from Patrick Gansterer included:
> I created only one pull request for my changes today, but all commits are independent.
On the proxy change one, it's normal in Unix to deliver the proxy by the
environment, we should not strip that out because Windows doesn't
understand the convention. Getting the proxy in the info struct is
good, but it should fall back to trying the env if it's NULL.
Can you also add something to the changelog explaining the priority change.
For the cast one, I dunno why that would be needed, since it's legal to
make a non-const pointer into a const one silently, just not the other
way around. But OK.
Cmake type check... sounds good thanks
Include + conditionals cleanout.... nice, can't really touch the win32
fungus nice to see it trimmed.
strerror stub... good verified it's OK with Linux still
UTF16 horror... okay
WINCE condiionals... okay
Thanks for the patches.
> You can merge this Pull Request by running:
> git pull https://github.com/paroga/libwebsockets fixes
> Or you can view, comment on it, or merge it online at:
> -- Commit Summary --
> * Set the HTTP proxy via creation info
> * Add explicit cast to setsockopt() calls
> * Fix type checks in CMake
> * Cleanup include statements
> * Add dummy implementation when strerror() is missing
> * Correctly server non-ASCII filenames on Windows
> * Enable compilation on Windows CE
> -- File Changes --
> M CMakeLists.txt (13)
> M lib/client.c (3)
> M lib/handshake.c (2)
> M lib/libwebsockets.c (32)
> M lib/libwebsockets.h (2)
> M lib/output.c (4)
> M lib/parsers.c (5)
> M lib/private-libwebsockets.h (13)
> M lib/server.c (9)
> M lib/sha-1.c (5)
> -- Patch Links --
> Reply to this email directly or view it on GitHub:
More information about the Libwebsockets