[Libwebsockets] most recent master commit / breaking changes?

Joel Winarske joel.winarske at gmail.com
Fri Mar 17 03:26:35 CET 2017


Regarding 1, thank you for pointing out the API change.  I resolved this.
I reverted code changes on 2 to check, and fstat is still failing.

On Thu, Mar 16, 2017 at 5:43 PM, Andy Green <andy at warmcat.com> wrote:

>
>
> On 03/17/2017 05:20 AM, Joel Winarske wrote:
>
>> Hi Andy,
>> I just did a pull on master, and now am seeing a couple issues with
>> things on Windows:
>> 1. When stepping into lws_vfs_file_open *flags == 0xcccccccc, not 0. No
>> idea what's up with this. It fails, unless I update the value to 0 in the
>> debugger.
>> uint32_t flags = LWS_O_RDONLY;
>> fd = lws_vfs_file_open(lws_get_fops(vhd->context), file, &filesize,
>> &flags);
>>
>
> Where is this code from?  It doesn't seem to exist in my tree.
>
> lws_vfs_file_open() now looks like this
>
> LWS_VISIBLE LWS_EXTERN lws_fop_fd_t LWS_WARN_UNUSED_RESULT
> lws_vfs_file_open(const struct lws_plat_file_ops *fops, const char
> *vfs_path,
>           lws_fop_flags_t *flags);
>
> if (fd == NULL) {
>> lwsl_notice("file not opened %s\n", file);
>> return -1;
>> }
>>
>> 2.  Serving is somehow broken.  I haven't changed my config file.  Is
>> there a breaking change, or modification required for conf file I missed?
>> The file is present.
>>
>> [2017/03/16 14:08:58:2111] INFO: Method: GET request for '/ui/index.html'
>> [2017/03/16 14:08:58:2121] INFO: client indicates GZIP is acceptable
>> [2017/03/16 14:08:59:6864] INFO: unable to stat
>> C:/etc/lwsws/www/ui/index.html
>> [2017/03/16 14:08:59:6874] INFO: LWS_CALLBACK_HTTP closing
>>
>> I get a break point on the last line.  This never happened before:
>> template <typename StatStruct>
>> static int __cdecl common_fstat(int const fh, StatStruct* const result)
>> throw()
>> {
>>     _VALIDATE_CLEAR_OSSERR_RETURN(result != nullptr, EINVAL, -1);
>>     *result = StatStruct{};
>>
>>     _CHECK_FH_CLEAR_OSSERR_RETURN(fh, EBADF, -1);
>>     _VALIDATE_CLEAR_OSSERR_RETURN(fh >= 0 && fh < _nhandle, EBADF, -1);
>>
>
> Is this possibly a fallout from 1)?
>
> -Andy
>
>
>>
>> Thanks,
>> Joel
>>
>>
>> _______________________________________________
>> Libwebsockets mailing list
>> Libwebsockets at ml.libwebsockets.org
>> https://libwebsockets.org/mailman/listinfo/libwebsockets
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://libwebsockets.org/pipermail/libwebsockets/attachments/20170316/74feb778/attachment-0002.html>


More information about the Libwebsockets mailing list