[Libwebsockets] lws_rx_flow_control problem
andy at warmcat.com
Wed Oct 11 01:00:13 CEST 2017
On 10/11/2017 06:52 AM, Per Bothner wrote:
> On 10/10/2017 03:35 PM, Andy Green wrote:
>> I just pushed an updated h2 patch where lws figures out for itself if
>> it should do the call. Basically in lws_rx_flow_control() it sets a
>> bit on the wsi saying it will do the call to _lws_rx_flow_control()
>> for that wsi, and clears the bit afterwards. If that bit isn't set on
>> the wsi, lws_rx_flow_control() does the call to _lws_rx_flow_control()
>> That should cover everything without needing to add the flag in user
> Not quite: If libwebsockets is 2.3 or older, then I never want to call
> lws_rx_flow_control(pty_wsi, 0) at all, since there is no way to
> re-enable flow.
> It may reasonable to use LWS_LIBRARY_VERSION_NUMBER, assuming you
> update it appropriately.
That is generated from the version number in CMakeLists.txt, it's
updated every release. But since there's no release since 2.3 on
master, it's still 2.3 there.
I updated it on master to 2.4 "early" to help with this.
More information about the Libwebsockets