[Libwebsockets] recent changes breaking DomTerm

Per Bothner per at bothner.com
Tue Jan 23 15:38:40 CET 2018


On 01/22/2018 11:43 PM, Andy Green wrote:

>> (2) Once I re-built libwebsockets with -DLWS_WITH_ZIP_FOPS=1 things
>> work for the 5b74d7108b5cfcc3a6ee3dcad521e0f0c3a18d0c, but things break
>> again two commits later:
>>
>>      commit df46d8827cc3c1ffd60ea5524b1074c014cd304b
>>      Date:   Thu Nov 16 11:26:00 2017 +0800
>>
>> I haven't tried to track down how this caused DomTerm to break.
> 
> Hm... it's a patch refactoring private stuff inside struct lws.
> 
> It breaks build or what?

The Electron/browser window never comes up - or only after a long timeout.

I notice this log difference:

GOOD (9039b7c9c64b3cd393e5aa4a26fc0827a7bb0a42/Date:   Thu Dec 7 10:09:56 2017 +0800):
[2018/01/23 06:18:45:0403] NOTICE: HTTP connect from localhost (127.0.0.1), path: /hlib/domterm-core.css
[2018/01/23 06:18:45:0403] DEBUG: lws_http_transaction_completed: wsi 0x12e9f30
[2018/01/23 06:18:45:0403] DEBUG: lws_ensure_user_space: 0x12e9f30 protocol pss 0, user_space=(nil)
[2018/01/23 06:18:45:0403] DEBUG: lws_set_timeout: 0x12e9f30: 5 secs
[2018/01/23 06:18:45:0403] DEBUG: lws_http_transaction_completed: wsi->more_rx_waiting=0
[2018/01/23 06:18:45:0403] DEBUG: wsi->http.rx_content_length 0 0 0
[2018/01/23 06:18:45:0403] DEBUG: lws_read: thinks we have used 0
[2018/01/23 06:18:45:0403] DEBUG: lws_handshake_server: wsi->more_rx_waiting=0
[2018/01/23 06:18:45:0403] DEBUG: lws_set_timeout: 0x12ea090: 0 secs
[2018/01/23 06:18:45:0403] DEBUG: lws_union_transition: 0x12ea090: mode 1
[2018/01/23 06:18:45:0403] DEBUG: lws_handshake_server: wsi 0x12ea090: ah 0x12ec7b0
[2018/01/23 06:18:45:0403] DEBUG: lws_ensure_user_space: 0x12ea090 protocol pss 0, user_space=(nil)
[2018/01/23 06:18:45:0404] DEBUG: lws_set_timeout: 0x12ea090: 5 secs
[2018/01/23 06:18:45:0404] NOTICE: HTTP connect from localhost (127.0.0.1), path: /hlib/domterm-standard.css
[2018/01/23 06:18:45:0405] DEBUG: lws_http_transaction_completed: wsi 0x12ea090
[2018/01/23 06:18:45:0405] DEBUG: lws_ensure_user_space: 0x12ea090 protocol pss 0, user_space=(nil)
[2018/01/23 06:18:45:0405] DEBUG: lws_set_timeout: 0x12ea090: 5 secs

BAD (1da0197798c3c19e5b60dd0e47b1724f08ce56de/Date:   Thu Dec 7 07:20:47 2017 +0800):
[2018/01/23 06:14:17:3497] NOTICE: HTTP connect from localhost (127.0.0.1), path: /hlib/domterm-core.css
[2018/01/23 06:14:17:3497] DEBUG: lws_close_free_wsi: 0x7d3f30
[2018/01/23 06:14:17:3497] DEBUG: _lws_change_pollfd: wsi 0x7d3f30: fd 11 events 1 -> 1
[2018/01/23 06:14:17:3497] DEBUG: lws_set_timeout: 0x7d3f30: 5 secs
[2018/01/23 06:14:17:3498] DEBUG: lws_handshake_server: wsi->more_rx_waiting=0
[2018/01/23 06:14:17:3498] DEBUG: lws_set_timeout: 0x7d4090: 0 secs
[2018/01/23 06:14:17:3498] DEBUG: lws_union_transition: 0x7d4090: mode 1
[2018/01/23 06:14:17:3498] DEBUG: lws_handshake_server: wsi 0x7d4090: ah 0x7d67b0
[2018/01/23 06:14:17:3498] DEBUG: lws_ensure_user_space: 0x7d4090 protocol pss 0, user_space=(nil)
[2018/01/23 06:14:17:3498] DEBUG: lws_set_timeout: 0x7d4090: 5 secs
[2018/01/23 06:14:17:3498] NOTICE: HTTP connect from localhost (127.0.0.1), path: /hlib/domterm-standard.css
[2018/01/23 06:14:17:3499] DEBUG: lws_close_free_wsi: 0x7d4090
[2018/01/23 06:14:17:3499] DEBUG: _lws_change_pollfd: wsi 0x7d4090: fd 12 events 1 -> 1
[2018/01/23 06:14:17:3499] DEBUG: lws_set_timeout: 0x7d4090: 5 secs

No lws_read or lws_http_transaction_completed.
-- 
	--Per Bothner
per at bothner.com   http://per.bothner.com/



More information about the Libwebsockets mailing list