[Libwebsockets] recent changes breaking DomTerm

Andy Green andy at warmcat.com
Wed Jan 24 03:13:35 CET 2018



On 23/01/18 22:38, Per Bothner wrote:
> On 01/22/2018 11:43 PM, Andy Green wrote:
> 
>>> (2) Once I re-built libwebsockets with -DLWS_WITH_ZIP_FOPS=1 things
>>> work for the 5b74d7108b5cfcc3a6ee3dcad521e0f0c3a18d0c, but things break
>>> again two commits later:
>>>
>>>      commit df46d8827cc3c1ffd60ea5524b1074c014cd304b
>>>      Date:   Thu Nov 16 11:26:00 2017 +0800
>>>
>>> I haven't tried to track down how this caused DomTerm to break.
>>
>> Hm... it's a patch refactoring private stuff inside struct lws.
>>
>> It breaks build or what?
> 
> The Electron/browser window never comes up - or only after a long timeout.
> 
> I notice this log difference:

> BAD (1da0197798c3c19e5b60dd0e47b1724f08ce56de/Date:   Thu Dec 7 07:20:47 
> 2017 +0800):
> [2018/01/23 06:14:17:3497] NOTICE: HTTP connect from localhost 
> (127.0.0.1), path: /hlib/domterm-core.css
> [2018/01/23 06:14:17:3497] DEBUG: lws_close_free_wsi: 0x7d3f30

Hm... does it act the same with master HEAD?  Although I try to go back 
in history and fix the original patch when I find I missed something, 
once the original patch is older than a couple of weeks or so this 
upheaval tends to upset people following master.  Then fixes go in later 
patches.

If it's the same I will try to reproduce.

-Andy



More information about the Libwebsockets mailing list