[Libwebsockets] trivial suggestion for LWS_LIBRARY_VERSION_PATCH and READMEs/release-checklist

Per Bothner per at bothner.com
Fri Oct 12 20:12:38 CEST 2018


Can I suggest changing READMEs/release-checklist from:

     Bump the PATCH part of the version to 99

     -set(CPACK_PACKAGE_VERSION_PATCH "0")
     +set(CPACK_PACKAGE_VERSION_PATCH "99")

to:

     Bump the PATCH part of the version to 1

    -set(CPACK_PACKAGE_VERSION_PATCH "0")
     +set(CPACK_PACKAGE_VERSION_PATCH "1")

This allows future incremental bumps of CPACK_PACKAGE_VERSION_PATCH.

Of course technically there is nothing wrong with LWS_LIBRARY_VERSION_PATCH >= 100,
but it seems awkward as long as patch numbers 1 to 98 are unused.  It seems
to imply patch numbers are frequently bumped, which is not the case.
-- 
	--Per Bothner
per at bothner.com   http://per.bothner.com/


More information about the Libwebsockets mailing list