<div dir="ltr"><div class="gmail_default" style="font-size:x-small">Thanks Andy.</div><div class="gmail_default" style="font-size:x-small"><br></div><div class="gmail_default" style="font-size:x-small">All good for the upgrade to 2.4.0.</div><div class="gmail_default" style="font-size:x-small"><br></div><div class="gmail_default" style="font-size:x-small">Thanks again,</div><div class="gmail_default" style="font-size:x-small"><br></div><div class="gmail_default" style="font-size:x-small">Brice.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 7, 2017 at 5:36 PM, Andy Green <span dir="ltr"><<a href="mailto:andy@warmcat.com" target="_blank">andy@warmcat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 12/08/2017 02:08 AM, Brice Hamon wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi guys.<br>
</blockquote>
<br>
Thanks Silas for the replies.<br>
<br>
I think you're probably using master... the patch on there that adds coverage support, it changes the cmake defaults for things that should have been default-off in the first place<br>
<br>
 - LWS_WITH_ZIP_FOPS: OFF<br>
 - LWS_WITH_RANGES: OFF<br>
 - LWS_WITHOUT_EXTENSIONS: ON<br>
 - LWS_WITH_ZLIB: OFF<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Quick update.<br>
<br>
Great news, the library is working in my environment. I am using an external epoll mecanism which also is working fine.<br>
<br>
The only new thing is a error log at startup from libwebsocket:  libwebsocket: lws_tls_server_certs_load: x is NULL<br>
<br>
Any ideas where this is coming from?<br>
</blockquote>
<br></span>
It's just a debug message, it's gone in current master.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I am not using vhost, and use the default behavior which, I believe, creates a default vhost for me.<br>
</blockquote>
<br></span>
Yes, for backwards compatibility if you don't set the context creation info option LWS_SERVER_OPTION_EXPLICIT_VHO<wbr>STS, creating the context will also create a vhost called "default" and configure it with whatever you set in the context creation info struct.  Stuff will "just work" like before.<br>
<br>
-Andy<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks<br>
Brice.<span class=""><br>
<br>
<br>
<br>
On Thu, Dec 7, 2017 at 12:45 PM, Brice Hamon <<a href="mailto:brice@ydotm.com" target="_blank">brice@ydotm.com</a> <mailto:<a href="mailto:brice@ydotm.com" target="_blank">brice@ydotm.com</a>>> wrote:<br>
<br>
    Hi Silas,<br>
<br>
    Thank you, you are correct. I had to explicitly<br>
    add -DLWS_WITHOUT_EXTENSIONS=O<wbr>FF to get the deflate symbol included<br>
    in the library.<br>
<br>
    The link is now successful.<br>
<br>
    Thank you for your help, greatly appreciated.<br>
<br>
    Brice.<br>
<br>
<br>
<br>
    On Thu, Dec 7, 2017 at 12:06 PM, Silas Parker<br>
    <<a href="mailto:skyhisi%2Blibwebsockets@gmail.com" target="_blank">skyhisi+libwebsockets@gmail.c<wbr>om</a><br></span><span class="">
    <mailto:<a href="mailto:skyhisi%2Blibwebsockets@gmail.com" target="_blank">skyhisi+libwebsockets@<wbr>gmail.com</a>>> wrote:<br>
<br>
        On 7 December 2017 at 16:50, Brice Hamon <<a href="mailto:brice@ydotm.com" target="_blank">brice@ydotm.com</a><br></span><span class="">
        <mailto:<a href="mailto:brice@ydotm.com" target="_blank">brice@ydotm.com</a>>> wrote:<br>
         > Hi Silas,<br>
         ><br>
         > No the Cmake was plain vanilla. Here is the build script I<br>
        used up to 2.2<br>
         ><br>
         > git clone git://<a href="http://git.warmcat.com/libwebsockets" rel="noreferrer" target="_blank">git.warmcat.com/libwebso<wbr>ckets</a><br></span>
        <<a href="http://git.warmcat.com/libwebsockets" rel="noreferrer" target="_blank">http://git.warmcat.com/libweb<wbr>sockets</a>><span class=""><br>
         > cd libwebsockets<br>
         > mkdir build<br>
         > cd build<br>
         > cmake ..<br>
        -DCMAKE_INSTALL_PREFIX:PATH=/e<wbr>xport/home/development/3rdpart<wbr>y -G<br>
         > "Unix Makefiles"<br>
         > make<br>
         > make install<br>
         ><br>
         > Thank you,<br>
         > Brice.<br>
         ><br>
         ><br>
         > On Thu, Dec 7, 2017 at 11:39 AM, Silas Parker<br>
         > <<a href="mailto:skyhisi%2Blibwebsockets@gmail.com" target="_blank">skyhisi+libwebsockets@gmail.c<wbr>om</a><br></span><span class="">
        <mailto:<a href="mailto:skyhisi%252Blibwebsockets@gmail.com" target="_blank">skyhisi%2Blibwebsocket<wbr>s@gmail.com</a>>> wrote:<br>
         >><br>
         >> On 7 December 2017 at 16:29, Brice Hamon<br></span><div><div class="h5">
        <<a href="mailto:normandviking@gmail.com" target="_blank">normandviking@gmail.com</a> <mailto:<a href="mailto:normandviking@gmail.com" target="_blank">normandviking@gmail.co<wbr>m</a>>> wrote:<br>
         >> > Hi guys,<br>
         >> ><br>
         >> > I upgraded from 2.2 to 2.4 and I am facing a link issue with<br>
         >> > libwebsockets<br>
         >> > when I tried to compile a simple client test program:<br>
         >> ><br>
         >> > g++ -W -Wall -Wpointer-arith -Werror=uninitialized  -g -pipe<br>
         >> > -D_REENTRANT<br>
         >> > -D_GNU_SOURCE  -I../ -I/export/home/bhamon/work/bs/<wbr>include<br>
         >> > -I/usr/local/include<br>
        -I/export/home/development/3rd<wbr>party/include<br>
         >> > -I/export/home/development/too<wbr>ls         -L/export/home/bhamon/work/<wbr>bs/lib<br>
         >> > -L/export/home/bhamon/work/bs/<wbr>lib -L./ -L/usr/local/lib<br>
         >> > -L/export/home/development/3rd<wbr>party/lib<br>
         >> > -L/export/home/development/3rd<wbr>party/lib64 -Wl,-E -o wsclient<br>
         >> > ./wsclient.o<br>
         >> > -lwebsockets -ldl -lpthread<br>
         >> > ./wsclient.o:(.rodata+0xe08): undefined reference to<br>
         >> > `lws_extension_callback_pm_def<wbr>late'<br>
         >> > ./wsclient.o:(.rodata+0xe20): undefined reference to<br>
         >> > `lws_extension_callback_pm_def<wbr>late'<br>
         >> > collect2: error: ld returned 1 exit status<br>
         >> ><br>
         >> > I checked your test-client program and we have the same code.<br>
         >> > I noticed that you link your program in static. I do use<br>
        the shared<br>
         >> > library.<br>
         >> ><br>
         >> > Is there anything special I need to add when I compile<br>
        that .4 version?<br>
         >> ><br>
         >> > Thank you,<br>
         >> > Brice.<br>
         >> ><br>
         >> > ______________________________<wbr>_________________<br>
         >> > Libwebsockets mailing list<br>
         >> > <a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwebsockets<wbr>.org</a><br></div></div>
        <mailto:<a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwe<wbr>bsockets.org</a>><br>
         >> > <a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mail<wbr>man/listinfo/libwebsockets</a><span class=""><br>
        <<a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mai<wbr>lman/listinfo/libwebsockets</a>><br>
         >> ><br>
         >><br>
         >><br>
         >> Hi Brice,<br>
         >><br>
         >> Have you set LWS_WITHOUT_EXTENSIONS to Off in CMake?<br>
         >><br>
         >> Thanks,<br>
         >> Silas<br>
         >> ______________________________<wbr>_________________<br>
         >> Libwebsockets mailing list<br>
         >> <a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwebsockets<wbr>.org</a><br></span>
        <mailto:<a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwe<wbr>bsockets.org</a>><br>
         >> <a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mail<wbr>man/listinfo/libwebsockets</a><span class=""><br>
        <<a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mai<wbr>lman/listinfo/libwebsockets</a>><br>
         ><br>
         ><br>
<br>
        Hi Brice,<br>
<br>
        The default is On, so I think you need to set LWS_WITHOUT_EXTENSIONS<br>
        to Off explicitly to built the deflate into libwebsockets.so.<br>
<br>
        You can check if your library has it with a command like:<br>
<br>
        nm -Dg lib/libwebsockets.so | grep deflate<br>
                          U deflate<br>
                          U deflateEnd<br>
                          U deflateInit2_<br>
        000000000001bee0 T lws_extension_callback_pm_defl<wbr>ate<br>
<br>
        You should see the symbol listed.<br>
<br>
        Thanks,<br>
        Silas<br>
        ______________________________<wbr>_________________<br>
        Libwebsockets mailing list<br>
        <a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwebsockets<wbr>.org</a><br></span>
        <mailto:<a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwe<wbr>bsockets.org</a>><br>
        <a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mail<wbr>man/listinfo/libwebsockets</a><br>
        <<a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mai<wbr>lman/listinfo/libwebsockets</a>><span class=""><br>
<br>
<br>
<br>
<br>
<br>
______________________________<wbr>_________________<br>
Libwebsockets mailing list<br>
<a href="mailto:Libwebsockets@ml.libwebsockets.org" target="_blank">Libwebsockets@ml.libwebsockets<wbr>.org</a><br>
<a href="https://libwebsockets.org/mailman/listinfo/libwebsockets" rel="noreferrer" target="_blank">https://libwebsockets.org/mail<wbr>man/listinfo/libwebsockets</a><br>
<br>
</span></blockquote>
</blockquote></div><br></div>